This repository was archived by the owner on May 21, 2025. It is now read-only.
chiadapter: support API Gateway Events V2 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed failing tests in #137 |
|
Failing tests are fixed in #131 |
|
I've synced the branch with master to fix the tests. |
|
Can we merge this |
|
as lambda urls only work with v2 format, this would be very useful if can be merged https://docs.aws.amazon.com/lambda/latest/dg/urls-invocation.html#urls-payloads |
drakejin
approved these changes
May 25, 2023
|
Oh my god. I am a maintainer! I didn't notice! |
|
@drakejin any news about when this is going to be merged? |
|
This is already supported? https://github.com/awslabs/aws-lambda-go-api-proxy/blob/master/chi/adapterv2.go |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #134 *
Description of changes:
I've implemented the support of Gateway Events V2 in chiadapter. I am not sure if everything is ok with the style you prefer, please, feel free to review it and I'll fix all the issues :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.